-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to use the full path for exclude folder/file #310
Open
mirecl
wants to merge
8
commits into
jendrikseipp:main
Choose a base branch
from
mirecl:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5fafd42
Add the ability to use the full path for exclude folder/file
mirecl 41f5d84
Fix linter pattern.startswith("./")
mirecl bbac147
Add test case for ./ exclude
mirecl 386f345
Fix linter for pattern.endswith(".py")
mirecl 068185c
Fix test case for exclude
mirecl 1ab3494
Add test_exclude_abs_path
mirecl 579f7a4
Update vulture/core.py
jendrikseipp 523dc37
Update vulture/core.py
jendrikseipp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
from fnmatch import fnmatch, fnmatchcase | ||
from pathlib import Path | ||
import pkgutil | ||
import os | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sort imports alphabetically. And use |
||
import re | ||
import string | ||
import sys | ||
|
@@ -261,6 +262,12 @@ def handle_syntax_error(e): | |
|
||
def scavenge(self, paths, exclude=None): | ||
def prepare_pattern(pattern): | ||
if pattern.startswith("./"): | ||
pattern = os.path.abspath(pattern) | ||
if os.path.isdir(pattern): | ||
pattern = os.path.join(pattern, "*") | ||
pattern = f"{pattern}/*" | ||
return pattern | ||
if not any(char in pattern for char in "*?["): | ||
pattern = f"*{pattern}*" | ||
return pattern | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will succeed even without the exclude. I suggest to use
vulture vulture/lines.py --exclude vulture/lines.py
instead. And have two tests: returncode == 0 with exclude, returncode != 0 without exclude.