Handle while True loops without break statements #378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the following example, the
print
statement is not recognized as unreachable code byvulture
.More general: If a
while True
statement has nobreak
, then the statement after thewhile True
is unreachable.Implementation
Introduce
self._current_loop_has_break_statement
in order to keep track ofbreak
statements found while traversing the AST.We cannot validate if the break statements only occur in loops (so we need to assume the code is correct). In order to check this properly, we would need to visit the parent first (and push some kind of context or scope; pop if after visiting the children).
Checklist
pre-commit run --all-files
to format and lint my code.