Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node from v16.18 to v18.19 #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

undefined-ux
Copy link

Description

Update Node.js version to 18.19

@mahula
Copy link

mahula commented Apr 6, 2024

Is this repository still under active development, @jenkey2011?
We are using the vuepress-deploy action in several project and are faced with WARN EBADENGINE Unsupported engine warnings related to the Docker image's Node version v16.19.1 while our projects' dependencies require higher versions (e.g. required: { node: '>=18.0.0' }, see this deployment workflow).
The v16.19.1 Docker Image has several strong vulnerabilities. It would be helpful to merge this PR.

@mahula
Copy link

mahula commented May 1, 2024

Hello @undefined-ux,
as said above we were also faced with WARN EBADENGINE Unsupported engine warnings related to the Docker image's Node version v16.19.1 while our projects' dependencies require higher versions.
Since this repo des not seem to be maintained anymore, we forked it and updated the Github Action's docker file node version to 20.12.1, which meets our requirements. We will continue to maintain int to keep this action current and useful
You can find it here.
Please give it a try and give feedback, how it works for your projects.
Kind regards,
@mahula from @IT4Change

@undefined-ux
Copy link
Author

Hello @undefined-ux, as said above we were also faced with WARN EBADENGINE Unsupported engine warnings related to the Docker image's Node version v16.19.1 while our projects' dependencies require higher versions. Since this repo des not seem to be maintained anymore, we forked it and updated the Github Action's docker file node version to 20.12.1, which meets our requirements. We will continue to maintain int to keep this action current and useful You can find it here. Please give it a try and give feedback, how it works for your projects. Kind regards, @mahula from @IT4Change

It works perfectly. Thank you for your continued work maintaining this project.

@Wulian233
Copy link

It's can be merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants