-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace master with main #7841
base: master
Are you sure you want to change the base?
chore: replace master with main #7841
Conversation
updated the branch . |
This seems like a lot of work with many, many opportunities for issues, without me being confident that @biru-codeastromer is ready for the weeks or months of issues that will result from the change. Have you checked the other documentation generation locations that contribute to the jenkins.io site, like the backend extension indexer and the pipeline steps documentation generator? Have you investigated the changelog generator tooling to confirm that it will continue to submit pull requests that are targeting the correct branch? |
Hi Sir , Thanks for your constructive feedback! I completely understand that such a broad change comes with long-term implications, and I appreciate your insights and concerns. Regarding your concerns: I thought it would be better to raise a PR for improvements, so I prepared this as a draft to initiate discussions and track areas that need further research. Since there’s still work and investigation left, you can keep this PR in draft mode while I continue my research. If you believe this is doable for me, I’d be happy to continue working on it. Thanks again Sir for your valuable feedback! Much appreaciated |
The list of files in #7126 also includes the issue templates, I think they should be included in the PR. |
Thanks for the feedback ! Will be including them in the PR now . |
I have added ! |
this file : "jenkins.io/updatecli/values.github-action.yaml" too has it as :
|
Hi @biru-codeastromer, is this intended to just be the jenkins.io github repo documentation update, or would the jenkins.io documentation pages be updated in this PR as well? I ask because when reviewing the documentation on jenkins.io, there are several uses of the master URL that would be updated here. If that will be a separate PR, please let me know and I'm happy to help gather all the usages and create a draft PR to make the accompanying updates. |
Hi @kmartens27 Sir, Thank you for your question and for offering to help! By observing the needs of the issue #7126 , This PR is currently focused on updating the GitHub repository documentation (e.g., I agree that the Jenkins.io documentation pages also need to be updated to replace Thanks |
As I advertised in an earlier issue @biru-codeastromer , this change is not an easy one. You cannot do it partially otherwise you'll break a LOT of things. We should not do it on multiple PRs but only one and sync when the change is pushed : this is not a simple code change. We should do it once for all or not do it. |
Hi Sir, I’ll ensure that all necessary references—including functional items. |
Hi @kmartens27 Sir, Since you mentioned finding several references to "master" in the Jenkins.io documentation, could you help gather them here so we can update everything in this PR? Let me know how you'd like to collaborate on this ! or any help from my side if you need . |
A good technique for such kind of contribution requiring other contributor help (if they can) is to have "PR of your PR", e.g. doing PRs in your fork, with the branch |
Got it Sir ! That sounds like a great approach. I'll check with @kmartens27 Sir to see if he would be willing to help with the Jenkins.io documentation updates directly in my forked repo (branch: https://github.com/biru-codeastromer/jenkins.io/tree/update-branch-references). If so, he can submit a PR there, and we can merge those changes into this PR to keep everything in sync. Thanks for your suggestions! |
I'm happy to help @biru-codeastromer, I've already started the process of determining what content would need to be updated in my own fork, so once I have everything together, I can submit a pull to your fork so that everything can be combined. |
Thank you very much for your immense help Sir. Much appreciated and looking forward to it! |
Fixes #7126
Description:
This PR replaces all instances of
master
withmain
in the codebase, documentation, and GitHub workflows.Changes include:
Please review and let me for further improvements !