Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hardcoding implicit JDK and workarround #580 #583

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Avoid hardcoding implicit JDK and workarround #580 #583

merged 1 commit into from
Jan 7, 2025

Conversation

jonesbusy
Copy link
Collaborator

Avoid hardcoding implicit JDK and workarround #580

Testing done

Tested with #580 and confirmed Java 11 is used in that case

Also avoid hardcoding implicit Java version if by any change jenkins-infra/pipeline-library#897 (comment) is merged

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added the chore label Jan 7, 2025
@jonesbusy jonesbusy marked this pull request as ready for review January 7, 2025 12:03
@jonesbusy jonesbusy merged commit 8d368d8 into jenkins-infra:main Jan 7, 2025
16 checks passed
@jonesbusy jonesbusy deleted the feature/jdk-default branch January 7, 2025 13:34
@jonesbusy jonesbusy mentioned this pull request Jan 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonesbusy