Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli) tracks GitHub git end-points #161

Conversation

jayfranco999
Copy link
Contributor

As per jenkins-infra/helpdesk#4398 (comment)

This PR tracks GitHub git end-points and updates the github_destination_address_prefixes target of kind: json

Tested locally with success:


TARGETS
========

updateGitHubIPs
---------------

**Dry Run enabled**

✔ - no changes detected:
        path "locals.github_destination_address_prefixes" already set to "192.30.252.0/22 185.199.108.0/22 140.82.112.0/20 143.55.64.0/20 2a0a:a440::/29 2606:50c0::/32 20.201.28.151/32 20.205.243.166/32 20.87.245.0/32 4.237.22.38/32 20.207.73.82/32 20.27.177.113/32 20.200.245.247/32 20.175.192.147/32 20.233.83.145/32 20.29.134.23/32 20.199.39.232/32 20.217.135.5/32 4.225.11.198/32 4.208.26.197/32 20.26.156.215/32 20.201.28.152/32 20.205.243.160/32 20.87.245.4/32 4.237.22.40/32 20.207.73.83/32 20.27.177.118/32 20.200.245.248/32 20.175.192.146/32 20.233.83.149/32 20.29.134.19/32 20.199.39.227/32 20.217.135.4/32 4.225.11.200/32 4.208.26.198/32 20.26.156.214/32", from file "terraform/modules/azure-jenkinsinfra-azurevm-agents/locals.tf", 


ACTIONS
========


=============================

SUMMARY:



✔ Update allowed GitHub inbound IPs:
        Source:
                ✔ [githubInboundIpV4] get GitHub git IPv4s
        Target:
                ✔ [updateGitHubIPs] Update allowed IPs


Run Summary
===========
Pipeline(s) run:
  * Changed:    0
  * Failed:     0
  * Skipped:    0
  * Succeeded:  1
  * Total:      1

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check says:

**15:12:37  ✔ - no changes detected:

15:12:37  	path "locals.github_destination_address_prefixes" already set to "192.30.252.0/22 185.199.108.0/22 140.82.112.0/20 143.55.64.0/20 2a0a:a440::/29 2606:50c0::/32 20.201.28.151/32 20.205.243.166/32 20.87.245.0/32 4.237.22.38/32 20.207.73.82/32 20.27.177.113/32 20.200.245.247/32 20.175.192.147/32 20.233.83.145/32 20.29.134.23/32 20.199.39.232/32 20.217.135.5/32 4.225.11.198/32 4.208.26.197/32 20.26.156.215/32 20.201.28.152/32 20.205.243.160/32 20.87.245.4/32 4.237.22.40/32 20.207.73.83/32 20.27.177.118/32 20.200.245.248/32 20.175.192.146/32 20.233.83.149/32 20.29.134.19/32 20.199.39.227/32 20.217.135.4/32 4.225.11.200/32 4.208.26.198/32 20.26.156.214/32", from file "terraform/modules/azure-jenkinsinfra-azurevm-agents/locals.tf", 

LGTM!

@dduportal dduportal merged commit 61205bc into jenkins-infra:main Dec 2, 2024
1 check passed
smerle33 added a commit that referenced this pull request Dec 5, 2024
…er-images build

revert #160 and following #161 #162 to allow all internet for outgoing port 22 as it fail the packer images built.
will have to investigate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants