Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: External secrets from vault #297

Merged
merged 1 commit into from
Sep 7, 2021
Merged

fix: External secrets from vault #297

merged 1 commit into from
Sep 7, 2021

Conversation

msvticket
Copy link
Member

This should fix that secrets failed to be populated from vault by kubernetes-external-secrets. The log of kubernetes-external-secrets showed errors like:
{"level":50,"time":1630943166224,"pid":17,"hostname":"kubernetes-external-secrets-7686994b8c-ldrwh","payload":{"response":{"statusCode":400,"body":{"errors":["invalid role name "jx-vault""]}}},"msg":"failure while polling the secret jx/lighthouse-hmac-token"}

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

This should fix that secrets failed to be populated from vault by kubernetes-external-secrets. The log of kubernetes-external-secrets showed errors like:
{"level":50,"time":1630943166224,"pid":17,"hostname":"kubernetes-external-secrets-7686994b8c-ldrwh","payload":{"response":{"statusCode":400,"body":{"errors":["invalid role name \"jx-vault\""]}}},"msg":"failure while polling the secret jx/lighthouse-hmac-token"}
@ankitm123 ankitm123 merged commit ffbfb2c into jenkins-x:master Sep 7, 2021
@mrmarcsmith
Copy link
Contributor

@msvticket I'm still seeing this error. I outlined my procedures in great detail in this issue: jx3-terraform-eks
#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants