-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore suppressed issues in sarif reports #1110
Ignore suppressed issues in sarif reports #1110
Conversation
Upstream change tomasbjerre/violations-lib#156. |
The check failures all seem to be either unrelated test timeouts or dependency-check timing out repeatedly, not sure if there's anything that needs doing about that |
return !(violation.getSpecifics().containsKey("suppressed") | ||
&& violation.getSpecifics().get("suppressed").equals("true")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SImplify with getOrDefault("suppressed", "false")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point! updated to match
Thanks for noting, I forgot to remove the invocation from the pom.xml. This part of the build is now configured in a profile. |
I think I fixed the timeout problems now, can you please merge with main? |
Ignore suppressions in SARIF reports, as them being suppressed should exclude them from the violations, and related quality gates in the warnings ng plugin
Testing done
Unit tests were updated and was run against a jenkins instance passing in a sarif file with suppressions, which were ignored correctly
Submitter checklist