Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74054] Extract inline script block in AbstractNameValueHeader/rowHeader.jelly #147

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Oct 31, 2024

JENKINS-74054

Testing done

  1. Create a pipeline similar to [JENKINS-73960] Extract event handlers in BuildCardExtension/buildCardTemplate.jelly #142
  2. For the upstream project, add a few random parameters.
  3. Go to the pipeline config settings and enable the below setting:
    Screenshot 2024-10-30 at 9 02 16 PM
  4. This will display parameters on the first card in the pipeline.
    Screenshot 2024-11-11 at 5 04 16 PM

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan shlomomdahan requested a review from a team as a code owner October 31, 2024 01:02
@shlomomdahan shlomomdahan mentioned this pull request Nov 4, 2024
6 tasks
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original functionality was broken. The tooltip was not appearing when hovering over the build number.

In the latest released version? I can't tell which portion of this diff is fixing a bug, if any.

@shlomomdahan
Copy link
Author

shlomomdahan commented Nov 8, 2024

Original functionality was broken. The tooltip was not appearing when hovering over the build number.

In the latest released version? I can't tell which portion of this diff is fixing a bug, if any.

@basil Apologies for not specifying.

In the original released version, the jQuery snippet was looking for an element build-parameters-trigger-...

There was no such element in the DOM. I added this ID to the <div> with the 'title' class.

@basil
Copy link
Member

basil commented Nov 8, 2024

In the original released version, the jQuery snippet was looking for an element build-parameters-trigger-...

Makes sense. Can we please split that bug fix into a separate PR so that this extraction is reviewable as an extraction and not two independent changes?

@shlomomdahan
Copy link
Author

@basil

Sure just created #156 for the split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants