-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-74054] Extract inline script block in AbstractNameValueHeader/rowHeader.jelly
#147
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original functionality was broken. The tooltip was not appearing when hovering over the build number.
In the latest released version? I can't tell which portion of this diff is fixing a bug, if any.
...centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
Outdated
Show resolved
Hide resolved
@basil Apologies for not specifying. In the original released version, the jQuery snippet was looking for an element There was no such element in the DOM. I added this ID to the |
Makes sense. Can we please split that bug fix into a separate PR so that this extraction is reviewable as an extraction and not two independent changes? |
JENKINS-74054
Original functionality was broken. The tooltip was not appearing when hovering over the build number.
AbstractNameValueHeader/rowHeader.jelly
#156 for the inline script which is extracted in this PR.The tooltip is necessary because the card lacks space to display all the parameters if many are present.
Testing done
BuildCardExtension/buildCardTemplate.jelly
#142Submitter checklist