apply jenkins styling to selects #472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove the obsolete blockwrapper
mawinter69
commented
Mar 1, 2025
| @@ -34,7 +33,7 @@ xmlns:fo="/lib/folder"> | |||
| (<i:formatDate value="${it.timestamp.time}" type="both" dateStyle="medium" timeStyle="medium"/>) | |||
| </j:if> | |||
| </t:buildCaption> | |||
| <fo:blockWrapper> | |||
| <table style="margin-top: 1em; margin-left:1em;"> | |||
There was a problem hiding this comment.
Actually it was wrong when the blockwrapper was introduced to use it here. The t:summary is explicitly requiring a surrounding table as it itself creates a <tr>
Though I couldn't find a way how to make this page show up anywhere. I think it would require having a ComputedFolder that keeps kind of an execution history of the computations but branch-api doesn't do that
mawinter69
changed the title
|
Might be a lot to ask, but could you introduce before/after screenshots in your pull request description? Thanks @mawinter69 |
done |
|
the test error looks unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also remove the obsolete blockwrapper
Before:
Selecting the default view
Moving an item
After:
Selecting the default view:
Moving an item
Testing done:
Gone to move page of a job and verified that it still works
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)