Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused env.props from build.sh #936

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: remove unused env.props from build.sh #936

wants to merge 3 commits into from

Conversation

lemeurherveCB
Copy link
Contributor

@lemeurherveCB lemeurherveCB commented Feb 6, 2025 •
edited
Loading

This file isn't used since #827

Testing done

CI

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherveCB lemeurherveCB marked this pull request as ready for review February 12, 2025 14:46
@lemeurherveCB lemeurherveCB requested a review from a team as a code owner February 12, 2025 14:46
@lemeurherveCB lemeurherveCB marked this pull request as draft February 12, 2025 22:04
@lemeurherveCB lemeurherveCB marked this pull request as ready for review March 2, 2025 13:24
@lemeurherveCB lemeurherveCB changed the title Remove unused env.props from build.sh chore: remove unused env.props from build.sh Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemeurherveCB @timja