Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch from Temurin base images to Temurin installer #404

Merged

Conversation

lemeurherve
Copy link
Member

This PR switches from Temurin base images to the Temurin installer.

Benefits:

  • Less layers to pull
  • Faster availability as we don't need to wait for every kind of images (OS/architecture) to be released
  • Simpler updatecli manifests (to be adapted in a follow-up pull request)

Notes:

  • Reuse the jdk-download scripts introduced in chore(linux): Switch from Temurin base images to Temurin JDK binaries docker#1847
  • The JDK21 preview build failed with the jdk download scripts, kept as is since it's already a bit different than the other Linux Dockerfiles.
  • For Windows images:
    • Using the happy path of api.adoptium.net, retrieving the MSI installer from jdk version only (retrieving it from the GitHub releases requires the use of several variation of the jdk version)
    • Using a Windows Server Core jdk-core base image for the nanoserver image: we can't use a nanoserver one as we need to retrieve some files from a Windows Server Core anyway.
    • Deliberately not including jlink in this pull request for Windows images as there is currently nothing in the repo capable of testing it properly (Generate smaller java runtime with jlink in Windows images docker-agent#788)

Ref:

Testing done

Local builds + CI

Submitter checklist

@lemeurherve lemeurherve requested a review from a team as a code owner May 14, 2024 10:22
timja
timja previously approved these changes May 14, 2024
timja
timja previously approved these changes May 14, 2024
MarkEWaite
MarkEWaite previously approved these changes May 14, 2024
@MarkEWaite MarkEWaite enabled auto-merge (squash) May 14, 2024 22:20
debian/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Hervé Le Meur <[email protected]>
@lemeurherve lemeurherve disabled auto-merge May 14, 2024 23:29
@lemeurherve lemeurherve merged commit 9aeb6f1 into jenkinsci:master May 14, 2024
9 checks passed
@lemeurherve lemeurherve deleted the helpdesk4029-temurin-installer branch May 14, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants