[JENKINS-75214] Added prioritization of SSH host key algorithms #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdesprez
commented
Feb 21, 2025
| @@ -0,0 +1,143 @@ | |||
| package hudson.plugins.ec2; | |||
There was a problem hiding this comment.
Note: refactoring, I extracted this class
jmdesprez
commented
Feb 21, 2025
| @@ -337,126 +327,6 @@ private ConnectionAttempt build(MockEC2Computer computer, ServerKeyVerifier veri | |||
| } | |||
| } | |||
|
|
|||
| // A mock ec2 computer returning the data we want | |||
There was a problem hiding this comment.
Note: refactoring, I extracted this class
jmdesprez
commented
Feb 21, 2025
| } | ||
|
|
||
| // Keep only supported algorithms | ||
| return NamedFactory.setUpBuiltinFactories(true, preferred); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://issues.jenkins.io/browse/JENKINS-75214
When a
HostKeyalready exists for theComputer, the algorithm is used as the preferred one to initiate the connection.🚨
ssh-ed25519supportPlease note that, as for now,
minadoesn't supportssh-ed25519out of the box. This support will be added in a future release: apache/mina-sshd#657.In the meantime, it is require to install https://plugins.jenkins.io/eddsa-api/ for
ssh-ed25519to be supported.Testing done
Note: I moved
MockEC2Computerto use it inSSHClientHelperTestSubmitter checklist