Migrate from Gradle IntelliJ Plugin (v1) to IntelliJ Platform Gradle Plugin (v2) #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Plugin (v2) * Add missing instrumentation and verification dependencies * Adjust `ideaVersion` compatibility based on new verifier expectations * Complete configuration of plugin verification * Adjust `Jenkinsfile` appropriately * Remove some `@NotNull` annotations which were breaking compilation
duemir
added
the
internal
|
This is still a draft because verifier stopped scanning all the versions between the current and the latest. And I cannot easily find a way to make it do it again. I need to ask on JetBrains Slack or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
No functional changes are expected. Only adopting a new version of the build system from JetBrains for futureproofing. Migrating from Gradle IntelliJ Plugin (1.x) | IntelliJ Platform Plugin SDK
JetBrains Annotations dependency shows up twice. Apparently, in two different versions.
@NotNullannotation in one hasElementType.TYPE_USE; in another - it doesn't. The latter is used during the compilation with the new gradle plugin. Hence, I had to remove a subset of the@NotNullannotations to make this plugin compile. I suspect once the baseline is updated, it will change and this annotation can be added back.Testing done
Submitter checklist