Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the plugin via Spotless #196

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link

@janfaracik janfaracik commented Nov 30, 2024

Small one to format the project via Spotless.

Copy link
Member

@duemir duemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really formatting, not linting, as far as I understand. That's semantics, though.
Is this the same formatting that Core uses and recommends for plugins?
Changing lineEndings is not recommended if I am reading https://github.com/diffplug/spotless/tree/main/plugin-gradle#line-endings-and-encodings-invisible-stuff correctly.

@timja
Copy link
Member

timja commented Dec 2, 2024

It's really formatting, not linting, as far as I understand. That's semantics, though. Is this the same formatting that Core uses and recommends for plugins? Changing lineEndings is not recommended if I am reading diffplug/spotless@main/plugin-gradle#line-endings-and-encodings-invisible-stuff correctly.

Core doesn't have much enabled but this is a subset of what plugins have enabled:
https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L648-L657

.gitattributes Show resolved Hide resolved
@janfaracik janfaracik changed the title Lint the plugin Format the plugin via Spotless Dec 2, 2024
@timja timja requested a review from duemir December 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants