[JENKINS-60884] - Fix NPE in Run API when using getPreviousBuildsOverThreshold #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
reviewed
Feb 3, 2020
timja
added
the
regression-fix
timja
approved these changes
Feb 3, 2020
Co-Authored-By: Zbynek Konecny <[email protected]>
oleg-nenashev
approved these changes
Feb 4, 2020
oleg-nenashev
added
the
ready-for-merge
res0nance
approved these changes
Feb 4, 2020
| if (r != null) { | ||
| return r.getBuildsOverThreshold(numberOfBuilds, threshold); | ||
| } | ||
| return new ArrayList<>(numberOfBuilds); |
There was a problem hiding this comment.
NIT-Non-blocking: Probably makes more sense for it to have no initial capacity
Suggested change
| return new ArrayList<>(numberOfBuilds); | |
| return new ArrayList<>(); |
There was a problem hiding this comment.
I agree but I chose to give it a capacity as this is what it would have returned in this case before being refactored.
My thought was to not change behavior no matter how insignificant. I can commit this suggestion if you still would recommend it after my comment.
StefanSpieker
approved these changes
Feb 4, 2020
|
Thanks for your contribution @AaronZurawski ! It should land in the next weekly |
|
Thanks everyone for the quick merge! |
oleg-nenashev
added
the
bug
jeffret-b
pushed a commit
to jeffret-b/jenkins
that referenced
this pull request
Feb 6, 2020
…Threshold (jenkinsci#4471) * Added a null check to getPreviousBuildsOverThreshold. * Cleaned up accidental newline. * Update core/src/main/java/hudson/model/Run.java Co-Authored-By: Zbynek Konecny <[email protected]> Co-authored-by: Zbynek Konecny <[email protected]>
jsoref
pushed a commit
to jsoref/jenkins
that referenced
this pull request
Feb 6, 2020
…Threshold (jenkinsci#4471) * Added a null check to getPreviousBuildsOverThreshold. * Cleaned up accidental newline. * Update core/src/main/java/hudson/model/Run.java Co-Authored-By: Zbynek Konecny <[email protected]> Co-authored-by: Zbynek Konecny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-60884.
This is fix for a NullPointerException in Run.getPreviousBuildsOverThreshold that was introduced by a refactor to add a new Run.getBuildsOverThreshold method in revision PR #4259
Proposed changelog entries
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeMaintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidate