Remove <optional> from config-file-provider dependency

[strangelookingnerd]

Remove the optional flag from the config-file-provider dependency.
To my understanding this dependency is directly referenced in ExecuteDslScripts as well as JenkinsDslScriptLoader and for that reason should not be optional.

Resolves jenkinsci/custom-folder-icon-plugin#280

Testing done

Ran existing tests without any errors.

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[strangelookingnerd]

@jenkinsci/job-dsl-plugin-developers any chance this can be reviewed, merged & released?

[jonesbusy]

Not a maintainer of job-dsl-plugin but it's weird for me to hard depends on the config-file-provider

What about

job-dsl-plugin/job-dsl-plugin/src/main/java/javaposse/jobdsl/plugin/ExecuteDslScripts.java

Line 611 in e6d655d

&& Jenkins.get().getPluginManager().getPlugin("config-file-provider") != null) {

This check if the plugin is installed

Also here :

job-dsl-plugin/job-dsl-plugin/src/main/java/javaposse/jobdsl/plugin/JenkinsDslScriptLoader.java

Line 26 in e6d655d

GlobalConfigFiles globalConfigFiles = GlobalConfigFiles.get();

[basil]

This plugin seems to comply with https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/ before this PR.

[strangelookingnerd]

This plugin seems to comply with https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/ before this PR.

This is true, however I'd argue that the ExecuteDslScripts and JenkinsDslScriptLoader can be considered core functionallities of this plugin. If these fail to load in case the optional dependency is not present, I don't see the point in them being optional.

[basil]

If these fail to load in case the optional dependency is not present, I don't see the point in them being optional.

Based on the Jenkins.get().getPluginManager().getPlugin("config-file-provider") != null) guard, they seem like they should load as described in https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/ -- are you saying that they aren't loading when the optional dependency is not present?

[strangelookingnerd]

Based on the Jenkins.get().getPluginManager().getPlugin("config-file-provider") != null) guard, they seem like they should load as described in https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/ -- are you saying that they aren't loading when the optional dependency is not present?

I was under the assumption, yes. However I fail to reproduce the error from jenkinsci/custom-folder-icon-plugin#280 / jenkinsci/maven-hpi-plugin#391

Closing the PR 👍🏼