Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Jenkins node (agent) mirroring into lockable-resource #486

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

mPokornyETM
Copy link
Contributor

See also #455

Thic change allow to mirror Jenkins nodes (agents) into lockable resources.
Following properties are mirrored.

  • name
  • labels
  • description

Testing done

Automatic test added

Proposed upgrade guidelines

N/A

Localizations

NN

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] For new APIs and extension points, there is a link to at least one consumer.
  • [ ] Any localizations are transferred to *.properties files.
  • [ ] Changes in the interface are documented also as examples.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There is at least one (1) approval for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically. See also release-drafter-labels.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • java code changes are tested by automated test.

@mPokornyETM mPokornyETM requested a review from a team as a code owner April 16, 2023 21:48
@mPokornyETM mPokornyETM added java Pull requests that update Java code documentation test lock Jenkins node Lockable resource interactions with Jenkins nodes. labels Apr 16, 2023
@mPokornyETM mPokornyETM added this to the Feature committed 2023 milestone Apr 16, 2023
@mPokornyETM mPokornyETM requested a review from g3n35i5 April 21, 2023 21:20
@mPokornyETM mPokornyETM merged commit 59db2b9 into jenkinsci:master Apr 26, 2023
@mPokornyETM mPokornyETM deleted the mirror-nodes-to-resources branch April 26, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement java Pull requests that update Java code lock Jenkins node Lockable resource interactions with Jenkins nodes. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants