Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lockable-resources build (job) page #673

Merged
merged 29 commits into from
Sep 17, 2024

Conversation

mPokornyETM
Copy link
Contributor

@mPokornyETM mPokornyETM commented Jun 19, 2024

Partly implement #667 with focus on performacne.
fix #703
The main change is to synchronized the addAction() per build and not global.
Also usage of getReadOnlyResources() is more or less obsolete, because all the actions provides in this plugin are synchronized correctly. That measn we spare a lot of memory and CPU by skipping the copy of all resources.

Testing done

My local tests (and also performance tests) looks fine

New LockableResources look on build page
image

tested also in #703

Proposed upgrade guidelines

N/A

Localizations

  • English
  • German
  • French
  • Slovak
  • Czech
  • ...

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] For new APIs and extension points, there is a link to at least one consumer.
  • Any localizations are transferred to *.properties files.
  • [ ] Changes in the interface are documented also as examples.

@mPokornyETM mPokornyETM self-assigned this Jun 19, 2024
@mPokornyETM mPokornyETM added enhancement java Pull requests that update Java code lock queue priority and visibility ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.) localization ready for review PR is ready for review labels Jun 19, 2024
@mPokornyETM mPokornyETM added this to the Feature committed milestone Jun 19, 2024
@mPokornyETM mPokornyETM marked this pull request as ready for review June 19, 2024 14:25
@mPokornyETM mPokornyETM requested a review from a team as a code owner June 19, 2024 14:25
@mPokornyETM mPokornyETM marked this pull request as draft June 20, 2024 06:28
@mPokornyETM mPokornyETM added megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours Merged without review ! This PR was marged without reviewers and removed megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours labels Sep 17, 2024
@mPokornyETM mPokornyETM enabled auto-merge (squash) September 17, 2024 11:12
@mPokornyETM mPokornyETM merged commit e218743 into jenkinsci:master Sep 17, 2024
12 of 15 checks passed
@mPokornyETM mPokornyETM deleted the feature/performance branch September 17, 2024 11:13
+ ", because the build has been finished.");
}
}
LOGGER.info(build.getFullDisplayName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log message got sort of lost in conversion? Also below.

cfoote added a commit to cfoote/lockable-resources-plugin that referenced this pull request Oct 22, 2024
cfoote added a commit to cfoote/lockable-resources-plugin that referenced this pull request Oct 23, 2024
cfoote added a commit to cfoote/lockable-resources-plugin that referenced this pull request Oct 23, 2024
cfoote added a commit to cfoote/lockable-resources-plugin that referenced this pull request Oct 31, 2024
cfoote added a commit to cfoote/lockable-resources-plugin that referenced this pull request Oct 31, 2024
cfoote added a commit to cfoote/lockable-resources-plugin that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement java Pull requests that update Java code localization lock queue priority and visibility Merged without review ! This PR was marged without reviewers ready for review PR is ready for review ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConcurrentModificationException when serializing LockedResourcesBuildAction#lockedResources
2 participants