-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve lockable-resources build (job) page #673
Merged
mPokornyETM
merged 29 commits into
jenkinsci:master
from
mPokornyETM:feature/performance
Sep 17, 2024
Merged
Improve lockable-resources build (job) page #673
mPokornyETM
merged 29 commits into
jenkinsci:master
from
mPokornyETM:feature/performance
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mPokornyETM
added
enhancement
java
Pull requests that update Java code
lock queue priority and visibility
ui
Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
localization
ready for review
PR is ready for review
labels
Jun 19, 2024
mPokornyETM
added
ready for review
PR is ready for review
and removed
work-in-progress
labels
Sep 9, 2024
mPokornyETM
added
megre in 24 hours without review
When nobody request a change or leave comment here I will merge it in 24 hours
Merged without review !
This PR was marged without reviewers
and removed
megre in 24 hours without review
When nobody request a change or leave comment here I will merge it in 24 hours
labels
Sep 17, 2024
jimklimov
reviewed
Sep 18, 2024
+ ", because the build has been finished."); | ||
} | ||
} | ||
LOGGER.info(build.getFullDisplayName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log message got sort of lost in conversion? Also below.
cfoote
added a commit
to cfoote/lockable-resources-plugin
that referenced
this pull request
Oct 22, 2024
cfoote
added a commit
to cfoote/lockable-resources-plugin
that referenced
this pull request
Oct 23, 2024
cfoote
added a commit
to cfoote/lockable-resources-plugin
that referenced
this pull request
Oct 23, 2024
cfoote
added a commit
to cfoote/lockable-resources-plugin
that referenced
this pull request
Oct 31, 2024
cfoote
added a commit
to cfoote/lockable-resources-plugin
that referenced
this pull request
Oct 31, 2024
cfoote
added a commit
to cfoote/lockable-resources-plugin
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
java
Pull requests that update Java code
localization
lock queue priority and visibility
Merged without review !
This PR was marged without reviewers
ready for review
PR is ready for review
ui
Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly implement #667 with focus on performacne.
fix #703
The main change is to synchronized the addAction() per build and not global.
Also usage of getReadOnlyResources() is more or less obsolete, because all the actions provides in this plugin are synchronized correctly. That measn we spare a lot of memory and CPU by skipping the copy of all resources.
Testing done
My local tests (and also performance tests) looks fine
New LockableResources look on build page
tested also in #703
Proposed upgrade guidelines
N/A
Localizations
Submitter checklist
[ ] New or substantially changed JavaScript is not defined inline and does not calleval
to ease the future introduction of Content Security Policy (CSP) directives (see documentation).[ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.[ ] For new APIs and extension points, there is a link to at least one consumer.[ ] Changes in the interface are documented also as examples.