Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ability to Append Maven Version Number to the end of the Build Name #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kungfujoe
Copy link

Hi!

I've modified your code to expose the option (in the form of a check box) to append the maven version number of the current release to the end of the Build name upon successful release.

For instance, if your Build Name is "#15" and the release version is "1.1.5", the build would be named (using my code) "#15 (v1.1.5)".

@buildhive
Copy link

Jenkins » m2release-plugin #4 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@kungfujoe
Copy link
Author

Thank you for the acknowledgement.

I read the webpage you sent me. If you would like to integrate and test my pull request, perform a maven release, and you'll see a new label that says "Append Release Version to Build name" with a checkbox next to it (located above the Dry Run check box). If you check it, it will append the maven version number to the build name if the build is successful. If I'm not mistaken, it will NOT append if the build fails.

Anyway, my main commit is all of 20 lines long. It's a pretty easy read. Nothing mind bending. I just tried to follow the format that you guys were using for the dry run check box, so I kind of did comments in the same format and whatnot. We've been using my pull in the office for several months now, and have not had any perceivable issue with it with any version of Jenkins.

If you have any questions, feel free to ask.
KFJ

P.S. I love Jenkins. It's an absolutely awesome piece of software.

On Jul 6, 2013, at 10:53 PM, Jenkins admin wrote:

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants