-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microsoft AD FS #368
Conversation
@@ -129,6 +129,36 @@ | |||
</pluginRepositories> | |||
|
|||
<build> | |||
<pluginManagement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to the change, but due to eclipse-m2e/m2e-core/issues/1291 would cause an error in the project in eclipse.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
============================================
- Coverage 72.02% 71.88% -0.14%
- Complexity 234 239 +5
============================================
Files 11 12 +1
Lines 990 1010 +20
Branches 142 145 +3
============================================
+ Hits 713 726 +13
- Misses 199 206 +7
Partials 78 78 ☔ View full report in Codecov by Sentry. |
AD FS returns data via a POST not a get, so this adapts the code to handle a call to finishLogin with via an HTTP POST.
@michael-doubez the metrics for code coverage appear broken. https://app.codecov.io/gh/jenkinsci/oic-auth-plugin/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=jenkinsci#7dda26682abc4c20fa99de9ee4c7c0aa-L1423 is showing -0.75% coverage ( The base used for the diff is 11 commits behind master, yet the base for this PR is jtnord@3df5338 which is the same as ![]() https://app.codecov.io/gh/jenkinsci/oic-auth-plugin is having the last report as |
code coverage upload is failing on the master branch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enable the plugin to work with AD FS which sends the user back to
securityRealm/finishLogin
with a HTTP Post.Adds a Crumb exclusion extension for this endpoint.
Extract any POST data provided into a fake URL so it can be fed to the google code in a way that it can work with
Adds some rudimentary docs
fixes #352
Testing done
Submitter checklist