[JENKINS-73849] [JEP-237] remove the ability to disable SSL and token validation in FIPS mode #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Google OAuth library which is in maintainance mode with a supported library (nimbusds via pac4j) The library requires that the Issuer is set to enforce security and there is no option to disable this requirement as it is mandated in the specificiation. As such users must first update to 4.355.v3a_fb_fca_b_96d4 to set the Issuer before updating to this version. fixes: jenkinsci#313
This changes the Google OAuth library which is in maintainance mode with a supported library (nimbusds via pac4j) The library requires that the Issuer is set to enforce security and there is no option to disable this requirement as it is mandated in the specificiation. As such users must first update to 4.355.v3a_fb_fca_b_96d4 to set the Issuer before updating to this version. fixes: jenkinsci#313
…-plugin into JENKINS_73849
Co-authored-by: Francisco Javier Fernandez <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1371,6 +1390,22 @@ | |||
| return this.doCheckFieldName(tokenFieldToCheckKey, FormValidation.ok()); | |||
| } | |||
|
|
|||
| @RequirePOST | |||
| public FormValidation doCheckDisableSslVerification(@QueryParameter Boolean disableSslVerification) { | |||
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
| } | ||
|
|
||
| @RequirePOST | ||
| public FormValidation doCheckDisableTokenVerification(@QueryParameter Boolean disableTokenVerification) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
============================================
- Coverage 71.91% 71.88% -0.03%
- Complexity 199 206 +7
============================================
Files 16 16
Lines 883 900 +17
Branches 120 126 +6
============================================
+ Hits 635 647 +12
- Misses 185 186 +1
- Partials 63 67 +4 ☔ View full report in Codecov by Sentry. |
olamy
previously approved these changes
Oct 11, 2024
PereBueno
changed the title
jtnord
changed the title
jtnord
changed the base branch from
master
to
dependabot/maven/master/com.puppycrawl.tools-checkstyle-10.18.2
jtnord
changed the base branch from
dependabot/maven/master/com.puppycrawl.tools-checkstyle-10.18.2
to
master
jtnord
reviewed
Oct 11, 2024
| @@ -65,20 +66,20 @@ public void testAuthenticate_withUsernamePasswordAuthenticationToken() throws Ex | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetAuthenticationGatewayUrl() throws IOException { | |||
| public void testGetAuthenticationGatewayUrl() throws IOException, Descriptor.FormException { | |||
There was a problem hiding this comment.
FYI: generally for test methods I would just use throws Exception to reduce any maintenance burden
jtnord
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-73849
https://github.com/jenkinsci/jep/tree/master/jep/237
When Jenknis is running in FIPS-140 mode, SSL and token verificaiton can no longer be disabled.
This change adds a form validation that will warn the user, fails with an
IllegalArgumentExceptionif trying to save regardless the warning and checks values onreadResolve, in case config file was manually modified, or the plugin has been upgraded and was configured before these checks where enabled.NOTE: This change does not ensure that the plugin is FIPS-140 compliant, and further changes are required.
Testing done
Added 3 tests and checked manually.
Submitter checklist