Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73892] un-inline script in config.jelly and fix existing behavior #427

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

shlomomdahan
Copy link
Contributor

@shlomomdahan shlomomdahan commented Oct 11, 2024

JENKINS-73892

Default behavior was broken, so I fixed it along with the CSP issue by adding the relevant class name to the element.

Broken default behavior: https://www.loom.com/share/d1ceff4bfb4a40748c4dc36415d2a18e

CSP_nonRestrictive: https://www.loom.com/share/9fac40c2ecf14c9496dad64cd56205aa

CSP_restrictive: https://www.loom.com/share/f934c52aa3644a9b9169f72579cb13fd

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan shlomomdahan requested a review from a team as a code owner October 11, 2024 14:18
@shlomomdahan shlomomdahan changed the title [JENKINS-73909] un-inline script in config.jelly and fix existing behavior [JENKINS-73909] un-inline script in config.jelly and fix existing behavior Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.88%. Comparing base (c98df34) to head (45809bf).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #427   +/-   ##
=========================================
  Coverage     71.88%   71.88%           
  Complexity      206      206           
=========================================
  Files            16       16           
  Lines           900      900           
  Branches        126      126           
=========================================
  Hits            647      647           
  Misses          186      186           
  Partials         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shlomomdahan

@jtnord jtnord merged commit 5b97484 into jenkinsci:master Oct 11, 2024
21 checks passed
@shlomomdahan shlomomdahan changed the title [JENKINS-73909] un-inline script in config.jelly and fix existing behavior [JENKINS-73892] un-inline script in config.jelly and fix existing behavior Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants