Allow SecurityRealm#getUserIdStrategy to be customizable

[eva-mueller-coremedia]

Allow SecurityRealm#getUserIdStrategy to be customizable. This way, the plugin can be aligned with the ID strategy of the configured Identity Provider.

This is necessary, when the configured Identity Provider works with case-sensitive usernames. The Jenkins default is case-insensitive. The default leads to unwanted behaviour, when the configured Identity Provider has case-sensitive usernames, i.e., if a user with name test-user logs in, then a new log-in by the user Test-User will return the data of user test-user.

Testing done

• Extend PluginTest.java to cover the case-sensitive and case-insensitive case.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (84359ac) to head (11877ae).
Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #493      +/-   ##
============================================
+ Coverage     71.73%   72.05%   +0.32%     
- Complexity      222      226       +4     
============================================
  Files            17       17              
  Lines          1033     1045      +12     
  Branches        148      148              
============================================
+ Hits            741      753      +12     
  Misses          201      201              
  Partials         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jtnord]

There is also the group strategy to cover.
There is code with all of this tested and ready that would conflict, so would recommend waiting for that rather than duplicating

[eva-mueller-coremedia]

Hi @jtnord - thanks for having a look at this PR.

There is also the group strategy to cover.
There is code with all of this tested and ready that would conflict, so would recommend waiting for that rather than duplicating

Unfortunately, I do not understand your remark. Do you mean: There is a not-yet-pushed branch which will cover the customizable ID strategy?

[jtnord]

Hi @jtnord - thanks for having a look at this PR.

There is also the group strategy to cover.
There is code with all of this tested and ready that would conflict, so would recommend waiting for that rather than duplicating

Unfortunately, I do not understand your remark. Do you mean: There is a not-yet-pushed branch which will cover the customizable ID strategy?

there is code that covers the id strategy changes for both users and groups that has not been pushed but will be shortly

[eva-mueller-coremedia]

Hi @jtnord - thanks for having a look at this PR.

There is also the group strategy to cover.
There is code with all of this tested and ready that would conflict, so would recommend waiting for that rather than duplicating

Unfortunately, I do not understand your remark. Do you mean: There is a not-yet-pushed branch which will cover the customizable ID strategy?

there is code that covers the id strategy changes for both users and groups that has not been pushed but will be shortly

Ok. Good to know. Looking forward to see the feature soon.

I assume, I can close this PR, right?!

[eva-mueller-coremedia]

Already implemented but not yet pushed.

[jtnord]

@eva-mueller-coremedia do you have a Jenkins Jira ID?

[eva-mueller-coremedia]

@jtnord No, I have no Jenkins Jira ID

[jtnord]

@jtnord No, I have no Jenkins Jira ID

@eva-mueller-coremedia would you mind signing up at https://accounts.jenkins.io/signup?

[eva-mueller-coremedia]

@jtnord No, I have no Jenkins Jira ID

@eva-mueller-coremedia would you mind signing up at accounts.jenkins.io/signup?

Done... My user name is eva_mueller

[jtnord]

@jtnord No, I have no Jenkins Jira ID

@eva-mueller-coremedia would you mind signing up at accounts.jenkins.io/signup?

Done... My user name is eva_mueller

@eva-mueller-coremedia can you perform a login on Jira, this is needed so that Jira sees your account. Appologies, I did not realize this was a necessary step.

[eva-mueller-coremedia]

Successfully logged in...

[eva-mueller-coremedia]

@jtnord - thanks for sharing. Looking forward to see the solution in a release! Thanks a lot.