Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add WarningAction when propagate: true #110

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

stuartrowe
Copy link
Contributor

Fix for https://issues.jenkins.io/browse/JENKINS-70844 which is a knock on from #107.

Looking at the implementation of BuildConditions in declarative pipelines, any WarningAction attached to a node within a stage will trigger the Unsuccessful condition. See BuildCondition.java#L165.

In order to maintain the previous behavior, only add the WarningAction when propagte: true.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@stuartrowe
Copy link
Contributor Author

@car-roll @olamy please review when you have a chance. Thanks!

@stuartrowe
Copy link
Contributor Author

Alternative fix which avoids undoing the behavior added by #107: jenkinsci/pipeline-model-definition-plugin#598.

@stuartrowe
Copy link
Contributor Author

CI job timed out / aborted on the linux-11 branch. Closing and re-opening to trigger another build.

@stuartrowe stuartrowe closed this Apr 3, 2023
@stuartrowe
Copy link
Contributor Author

Triggering another PR build.

@stuartrowe stuartrowe reopened this Apr 3, 2023
@olamy olamy added the bug label Apr 4, 2023
@olamy olamy merged commit 8993df1 into jenkinsci:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants