-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spotless run and apply to all files #715
Conversation
@bguerin I know this is changing a lot of files. but no choice to make this incremental :) |
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
...line-maven/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepOnMasterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Olivier Lamy <[email protected]>
Also, if POMs are now handle by spotless plugin, no need for |
FYI build is failing because the module |
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
yup sorry I have been busy with something else. it should be fixed now. |
Signed-off-by: Olivier Lamy <[email protected]>
@@ -288,7 +287,8 @@ | |||
} | |||
|
|||
@Restricted(NoExternalUse.class) // Only for UI calls | |||
public ListBoxModel doFillGlobalMavenSettingsConfigItems(@AncestorInPath Item item, @AncestorInPath ItemGroup context) { | |||
public ListBoxModel doFillGlobalMavenSettingsConfigItems( |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
@Restricted(NoExternalUse.class) // Only for UI calls | ||
public ListBoxModel doFillMavenSettingsConfigItems(@AncestorInPath Item item, @AncestorInPath ItemGroup context) { | ||
public ListBoxModel doFillMavenSettingsConfigItems( |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
...n/src/test/java/org/jenkinsci/plugins/pipeline/maven/DependencyFingerprintPublisherTest.java
Outdated
Show resolved
Hide resolved
pipeline-maven/src/test/java/org/jenkinsci/plugins/pipeline/maven/DependencyGraphTest.java
Outdated
Show resolved
Hide resolved
Line 110 of the main POM ( |
Signed-off-by: Olivier Lamy <[email protected]>
it looks to fail on Windows because files were initially wrongly created.... |
No worry, I understand, thanks a lot for all you work until here Maybe you could grant me write access to you branch so I can end and merge this. I would like to merge this before others |
|
Ok, nice, thanks ! |
No description provided.