Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byte buddy dependency declaration #827

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Aug 18, 2024

Remove byte buddy dependency declaration

No need to declare it in the dependency management section when is included as a transitive dependency as needed by the tests.

Testing done

Confirmed that automated tests pass on Linux with JDK 21.0.4

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

No need to use byte buddy library when API plugin is available
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 18, 2024 15:27
pom.xml Outdated Show resolved Hide resolved
@MarkEWaite MarkEWaite changed the title Test with byte buddy API plugin Remove byte buddy dependency declaration Aug 19, 2024
@olamy olamy merged commit d0987eb into jenkinsci:master Aug 19, 2024
16 checks passed
@MarkEWaite MarkEWaite deleted the use-byte-buddy-api-plugin branch August 19, 2024 02:44
@MarkEWaite MarkEWaite restored the use-byte-buddy-api-plugin branch August 26, 2024 23:32
@MarkEWaite MarkEWaite deleted the use-byte-buddy-api-plugin branch December 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants