Make WithScriptAllowlist look up instances of WithScriptDescriptor dynamically instead of registering allowed scripts directly #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namically instead of registering allowed scripts directly
dwnusbaum
commented
Jan 9, 2024
Comment on lines
+106
to
+107
| for (WithScriptDescriptor descriptor : ExtensionList.lookup(WithScriptDescriptor.class)) { | ||
| URL scriptResource = descriptor.getScriptResource(); |
There was a problem hiding this comment.
This will be slower than before. I suspect it would be ok as-is, but jenkinsci/workflow-cps-plugin#829 will cache all of the allowlist responses, which should make performance a non-issue.
jglick
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/workflow-cps-plugin#538 (comment) and jenkinsci/workflow-cps-plugin#538 (comment).
I have not been able to reproduce the issue yet, so this is just a speculative change.