Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-57816] Self-Promotion Condition feature with Pipeline Compatibility #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dernDren161
Copy link
Contributor

@dernDren161 dernDren161 commented Jun 19, 2019

To show the compatibility of Self promotion with the pipelines.
Please go through this documentation to know more about the PR and my relevant questions.

See JENKINS-57816.

Your checklist for this pull request

  • Pull request title represents the changelog entry which will be used in Release Notes. JIRA issue is a part of the title (see existing PRs as examples)
  • Please describe what you did. Short summary for reviewers. If the change involves WebUI, add screenshots
  • Link to relevant Jenkins JIRA issues or pull requests
  • Test automation, if relevant. We expect autotests for all new features or complex bugfixes
  • Documentation if relevant (new features). We want to use Documentation-as-Code, just put docs to README or to new Doc files
  • Javadoc for new APIs. Any public/protected method is considered as API unless annotated by Restricted (docs)

CC

@oleg-nenashev @MadsNielsen @jonbrohauge @bicschneider

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is it. In https://issues.jenkins-ci.org/browse/JENKINS-57637 and the discussions over past weeks we agreed that you refactor the extension points, But here you create new ones instead of doing that.

import java.util.ArrayList;
import java.util.List;

public abstract class PipelinePromotionCondition implements ExtensionPoint, Describable<PipelinePromotionCondition> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need in separate extension point. The existing ones should be refactored as we agreed before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants