JENKINS-24271: Re-execute and Force permissions must be separated #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
… button to appear
| </j:when> | ||
| </j:choose> | ||
| <j:choose> | ||
| <j:if test="${!p.isManuallyApproved()}"> |
There was a problem hiding this comment.
It's better to use spaces separators if you change codelines. The original tabs separator seems to be incorrect
|
The change looks reasonable to me. Added several minor comments |
|
I suspect it will be a breaking change. The fix needs a more graceful permissions handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following approach is used:
Current "promote" permission is now used as "force" permission(after upgrading plugin all users with "promote" permission will have "force" permission. New permission "re-execute" is added.