Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a div container wrapping promotion details in order to ease styling #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mtauzin
Copy link

@mtauzin mtauzin commented Jun 15, 2015

No description provided.

Added a div container wrapping promotion details in order to ease styling
@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

</j:choose>
</div>

<div class='promotion-details'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong number of tabs

@oleg-nenashev
Copy link
Member

Such approach may impact other UI patches, but probably it's the only way

@oleg-nenashev
Copy link
Member

@mtauzin
Do you consider any CSS styling for this class? If yes, it could be done in the plugin directly (if it is generic enough)

@mtauzin mtauzin closed this Aug 25, 2015
@mtauzin
Copy link
Author

mtauzin commented Aug 25, 2015

@oleg-nenashev
Yes I do, the current style i'm applying throught css is :
padding-left: 40px; border-left:2px solid black;
css

@mtauzin mtauzin reopened this Aug 25, 2015
@oleg-nenashev
Copy link
Member

It would make sense as a default behavior (sorry for a necro-post, have missed the response)

@oleg-nenashev
Copy link
Member

Can be merged. There is just a mess with tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants