Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appearance of editor #946

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Oct 19, 2024

This PR sets out to update the appearance of the pipeline editor, updating it to the Jenkins variables (such as the color palette, fonts) for consistency and making it a little larger too.

Before

image

After

image image

Key changes

  • Use Jenkins color palette
  • Increase height from 250px to 350px
  • Use system monospace font
  • Icons and animations updated

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@daniel-beck
Copy link
Member

I expect that nobody will find the new link location in the description. Could it be made more visible?

@janfaracik janfaracik marked this pull request as ready for review January 11, 2025 12:06
@janfaracik janfaracik requested a review from a team as a code owner January 11, 2025 12:06
@jtnord
Copy link
Member

jtnord commented Jan 13, 2025

where has the help icon gone?
before:
image
after:
image

@@ -1,4 +0,0 @@
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whilst this was not the best help - it did at least prompt users where to look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored it.

@jglick jglick requested a review from jtnord January 14, 2025 21:30
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change look one to me. Have not run the pr in any circumstances context (proprietary or other.)
ATH appears to be unaffected.

Will wait to give @daniel-beck a chance to rereview

@jtnord jtnord requested a review from a team January 15, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants