Skip to content

Commit

Permalink
you kill, not cancel, actors (stanford-crfm#871)
Browse files Browse the repository at this point in the history
  • Loading branch information
dlwh authored Jan 29, 2025
1 parent d9a0d57 commit 0ad8c54
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/levanter/infra/ray_tpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def do_run(self, remote_fn, coordinator_ip, slice_id, num_slices) -> _TpuRunResu
logger.exception(e)
for actor in actors:
try:
ray.cancel(actor)
ray.kill(actor)
except Exception:
logger.exception("Failed to kill actor after primary failure")
return futures
Expand Down

0 comments on commit 0ad8c54

Please sign in to comment.