Image render fix for chapters 25, 26, and 32 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 14, 2023 15:19
…h single inner quotes the images now render
…h single inner quotes the images now render
…h single inner quotes the images now render
…h single inner quotes the images now render
|
Thanks! Do we still need to back slash escape the internal quotes, now that we're using single quotes inside of double quotes? |
Turns out, no! I removed the escapes from the single quotes and it renders fine for me. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jenny! Love this book so much and use it more frequently these days.
I noticed images not rendering in these chapters. Html was in their place. The culprit seems to be nested double quotes in the fig.alt chunk options. I changed those to single quotes. The images now render when I build.