Partial fix for pytest on Windows #1338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests fail on Windows with the following
> ___________ ERROR collecting tests/source_file/test_source_file.py ____________
> tests\source_file\test_source_file.py:24: in <module>
> class testOSError(unittest.TestCase):
> tests\source_file\test_source_file.py:39: in testOSError
> @unittest.skipIf("SUDO_UID" in os.environ.keys() or os.geteuid() == 0, "We are root. Root always has permissions so test will fail.")
> E AttributeError: module 'os' has no attribute 'geteuid'
Catch the AttributeError and attempt to check for admin when on Windows
Signed-off-by: Brandon Maier <[email protected]>
A large number of tests fail on Windows with the following error > ________ test_severity_using_main.test_architecture_with_configuration ________ > [gw0] win32 -- Python 3.8.20 %PREFIX%\python.exe > > self = <tests.severity.test_main.test_severity_using_main testMethod=test_architecture_with_configuration> > > def test_architecture_with_configuration(self): > try: > > subprocess.check_output(["bin/vsg", "-f", self._sArchitectureFileName, "-c", sConfigFile]) > > tests\severity\test_main.py:86: > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ > ..\_test_env\lib\subprocess.py:415: in check_output > return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, > ..\_test_env\lib\subprocess.py:493: in run > with Popen(*popenargs, **kwargs) as process: > ..\_test_env\lib\subprocess.py:858: in __init__ > self._execute_child(args, executable, preexec_fn, close_fds, ... > E FileNotFoundError: [WinError 2] The system cannot find the file specified > ..\_test_env\lib\subprocess.py:1327: FileNotFoundError Tests that call "bin/vsg" are relying on the Unix shebang (e.g. "#!/usr/bin/python") to launch `vsg` using the Python interpreter, But this is not supported on Windows. Instead launch `vsg` with Python directly. Signed-off-by: Brandon Maier <[email protected]>
Many of the tests that compare `vsg` stdout fail with a warning as
follows.
> First differing element 0:
> 'ERRO[19 chars]1.vhd(7)port_007 -- Change number of spaces after *in* to 4.\r'
> 'ERRO[19 chars]1.vhd(7)port_007 -- Change number of spaces after *in* to 4.'
The tests use `.split('\n')` to split stdout and stderr by the Linux
line terminator '\n'. But on Windows this causes test failures as the
line terminator is '\r\n'.
Instead use Python `.splitlines()`. which will split on both Linux and
Windows style line terminators. `.splitlines()` also removes empty
trailing lines, so we must modify the expected output accordingly.
Signed-off-by: Brandon Maier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some of the issues running the tests on Windows.
os.geteuid()to detect root uservsgaspython vsgso tests don't rely on Unix shebangstr.splitlines()Additional context
Resolves #1334