Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#1250: Corrected alignment of multiline variable and signal declarations for align_left = no #1345

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

JHertz5
Copy link
Contributor

@JHertz5 JHertz5 commented Dec 11, 2024

Resolves #1250.
I found that the extra space is present for "align_left_no__align_paren_no" and "align_left_no__align_paren_yes", so I've made adjustments to both.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (1772081) to head (86576b6).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1345   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files        1749     1749           
  Lines       31000    31032   +32     
  Branches     3462     3453    -9     
=======================================
+ Hits        29258    29289   +31     
  Misses       1328     1328           
- Partials      414      415    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremiah-c-leary
Copy link
Owner

Evening @JHertz5 ,

Could you resolve the conflicts with master?

Thanks,

--Jeremy

@JHertz5 JHertz5 changed the title Issue#1250: Corrected alignment of multiline variable and signal declarations for "align_left: no, align_paren: yes" Issue#1250: Corrected alignment of multiline variable and signal declarations for align_left = no Dec 12, 2024
@JHertz5
Copy link
Contributor Author

JHertz5 commented Dec 12, 2024

@jeremiah-c-leary I've updated the branch and resolved the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment incorrect for range declarations of unconstrained record elements spread over multiple lines
2 participants