Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a TLSConfig option #67

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Add a TLSConfig option #67

merged 5 commits into from
Nov 11, 2024

Conversation

k-anshul
Copy link
Contributor

This PR adds a TLSConfig options apart from existing Certificates.
Clients can set GetCertificate inside tls.Config which enables zero downtime certificate rotation

jeroenrinzema
jeroenrinzema requested changes Aug 12, 2024
View reviewed changes
handshake.go Outdated Show resolved Hide resolved
@jeroenrinzema jeroenrinzema added the enhancement New feature or request label Aug 12, 2024
jeroenrinzema
jeroenrinzema approved these changes Nov 11, 2024
View reviewed changes
Copy link
Owner

@jeroenrinzema jeroenrinzema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @k-anshul! I have implemented the requested changes as discussed

@jeroenrinzema jeroenrinzema merged commit f85f855 into jeroenrinzema:main Nov 11, 2024
2 checks passed
@k-anshul
Copy link
Contributor Author

Thanks @k-anshul! I have implemented the requested changes as discussed

Thanks @jeroenrinzema
Apologies for not being able to address your comments. I got caught up in some other tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroenrinzema jeroenrinzema jeroenrinzema approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-anshul @jeroenrinzema