Look up the class discriminator value by its name in the PolymorphismDecoder #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state
The PolymorphismDecoder expects the first field in the BSON document (or the second, if the first one is the
_id
) to contain the class discriminator. If the discriminator field is at another position in the document, deserialization fails.Example:
Parsing the following document
leads to
Proposed solution
With this pull request,
decodeElementIndex
actively looks for a field with the configured class discriminator's name. It also allows removing thealreadyReadId
parameters introduced in #19.This change adds a few more read calls, but I think the tradeoff is worth it for a bit more robustness.