Collapse/uncollapse all files in tree #4131
Open
+128
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could imagine
I would probably do separate ones. For toggling it wouldn't be quite clear what the exact logic would be.
Yes, in |
That sounds good to me |
Seems like this feature is highly requested jesseduffield#4095 jesseduffield#3554 Did a quick wip pr. I got the core functionality working with files and had some questions on what can be improved in order to polish it more. I.e. What keymaps if any to add to these, should the functionality be to toggle vs collapse and uncollapse separately, and if this should be added anywhere else (right now it's just for the file tree) Once I figure this out I can add the tests, documentations and anything else that's missing. I'm also pretty new to the language so if there's a way I can structure this better please let me know
mtrajano
force-pushed
the
feature/collapse-all
branch
from
9ee58f0 to
ffffe2e
Compare
mtrajano
changed the title
mtrajano
force-pushed
the
feature/collapse-all
branch
2 times, most recently
from
f01a8fe to
ffffe2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this feature is highly requested #4095 #3554
Ability to collpase/expand all files in the tree both for working files and commit view files. One issue I noticed is that currently any functionality that we want to add related to the file tree has to be duplicated across both controllers/models. I would like to try to unite the functionality using generics but I would prefer if it was done as part of a separate PR as it will greatly increase the scope of this PR and doesn't look trivial. Any feedback is welcome, thanks!
Example of functionality working:
