Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to half-screen mode when opening with certain CLI args #4141

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Jan 2, 2025

It should have been half-screen from the get-go. I think I just used full-screen to make demos look nicer. Now that we have a CLI arg for the screen mode we can make use of that in the demos.

Relates to #3042

  • PR Description

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

… CLI arg

It should have been half-screen from the get-go. I think I just used
full-screen to make demos look nicer. Now that we have a CLI arg for the
screen mode we can make use of that in the demos.
@jesseduffield jesseduffield changed the title Default to half-screen mode when filtering files or using the git-arg… Default to half-screen mode when opening with certain CLI args Jan 2, 2025
@jesseduffield jesseduffield added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 2, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 536ef821 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (536ef82) Report Missing Report Missing Report Missing
Head commit (621229b) 51539 44527 86.39%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4141) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jesseduffield jesseduffield merged commit 16a158a into master Jan 2, 2025
14 of 15 checks passed
@jesseduffield jesseduffield deleted the default-to-half-screen branch January 2, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant