Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): fix repository url; add homepage and bugs urls #1673

Closed
wants to merge 2 commits into from

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Nov 18, 2024

The repository URL was fixed by simply running npm pkg fix, which is what npm publish does prior to publishing.

The addition of the homepage property allows for the URL to the repo to be correctly displayed when hovered over in VS Code when using a proxy registry like in Azure DevOps:

image

Compared to eslint-plugin-regexp, which does have the homepage set:

image

The bugs property was also added to allow for npm bugs to work.

@Fdawgs Fdawgs changed the title chore(package): fix repository url; add homepage url chore(package): fix repository url; add homepage and bugs urls Nov 18, 2024
@Fdawgs Fdawgs closed this Dec 17, 2024
@Fdawgs Fdawgs deleted the patch-1 branch December 17, 2024 16:53
@G-Rath
Copy link
Collaborator

G-Rath commented Dec 19, 2024

hey sorry I was out sick and this completely missed this - if you wouldn't mind re-opening and running npx sort-package-json, I'm happy to land this

@Fdawgs
Copy link
Contributor Author

Fdawgs commented Dec 23, 2024

No worries @G-Rath, I was just doing a pre-Christmas/New Year clean of my forks. I'll open a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants