-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-haste-map): Fix slowdown on node versions > 10 (second attempt) #8806
Conversation
…emove async/await
…code flow is cleaner now
Codecov Report
@@ Coverage Diff @@
## master #8806 +/- ##
=========================================
Coverage ? 62.32%
=========================================
Files ? 266
Lines ? 10730
Branches ? 2614
=========================================
Hits ? 6687
Misses ? 3460
Partials ? 583
Continue to review full report at Codecov.
|
Huh, interesting that this seems to fix the OOM we get with circus... Question - is the issue fixed by just keeping https://github.com/facebook/jest/blob/fafaf893575000ca423dc77aa8aa44554cdb3f57/babel.config.js#L30 |
@SimenB Yes, at least for node 12.8.0 setting target to node: 8 in babel.config.js also fixes issue with metro. |
I still think that code without async/await looks cleaner and more understandable. |
#8787 landed, thanks for the PR (and checking babel config)! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is second attempt (first was #8803 and was incorrect, I definitely should run tests)
Fixes facebook/metro#429 for example.
Yes here is #8787, but I will try anyway. This time I split commits to small chunks. I prefer to eliminate any async/await syntax from file not only because it triggers some strange bugs in v8, but mostly because this syntax is ugly and leads to hard-to-understand code while promise based api is more clean (from my point of view).