Handle Cart Sample corner cases

jet · Dec 21, 2018 · f443417 · f443417
1 parent a946bf0
commit f443417
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/samples/Store/Domain.Tests/CartTests.fs b/samples/Store/Domain.Tests/CartTests.fs
@@ -75,8 +75,15 @@ let verifyIdempotency (cmd: Command) (originState: State) =
     // Assert we decided nothing needs to happen
     test <@ List.isEmpty events @>
 
-[<DomainProperty(MaxTest = 1000)>]
+/// These cases are assumed to be covered by external validation, so logic can treat them as hypotheticals rather than have to reject
+let isValid = function
+    | PatchItem (_, _, Some quantity, _)
+    | AddItem (_, _, quantity) -> quantity >= 0 
+    | _ -> true
+
+[<DomainProperty>]
 let ``interpret yields correct events, idempotently`` (cmd: Command) (originState: State) =
+    if not (isValid cmd) then () else
     verifyCanProcessInInitialState cmd originState
     verifyCorrectEventGenerationWhenAppropriate cmd originState
     verifyIdempotency cmd originState
diff --git a/samples/Store/Domain/Cart.fs b/samples/Store/Domain/Cart.fs
@@ -54,7 +54,7 @@ module Commands =
         let itemExistsWithDifferentWaiveStatus skuId waive  = itemExists (fun x -> x.skuId = skuId && x.returnsWaived <> waive)
         let itemExistsWithDifferentQuantity skuId quantity  = itemExists (fun x -> x.skuId = skuId && x.quantity <> quantity)
         let itemExistsWithSameQuantity skuId quantity       = itemExists (fun x -> x.skuId = skuId && x.quantity = quantity)
-        let itemExistsWithSkuId skuId                       = itemExists (fun x -> x.skuId = skuId)
+        let itemExistsWithSkuId skuId                       = itemExists (fun x -> x.skuId = skuId && x.quantity <> 0)
         let toEventContext (reqContext: Context)            = { requestId = reqContext.requestId; time = reqContext.time } : Events.ContextInfo
         let (|Context|) (context : Context)                 = toEventContext context
         match command with