Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cosmos): Use Azure.Cosmos STJ impl #467

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Sep 7, 2024

  • Use the in-the-box System.Text.Json support provided in Microsoft.Azure.Cosmos
  • CosmosStoreConnector: Remove requestTimeout mandatory argument - the particulars of tuning that are a lower level concern best left to the SDK team to manage (they've adjusted it from 5 to 6 seconds internally, and their retry logic is tuned and managed in accordance with the CosmosDB Service's SLAs and/or behavior under stress to a degree that neither Equinox or applications have much business concerning themselves with)
    • NOTE the parameter is still exposed for backcompat, and it continues to be something you want to consider taking ownership of if your calls/queries affect the user experience

@bartelink bartelink force-pushed the cosmos-default-stj branch 4 times, most recently from 067ffbd to b467431 Compare September 7, 2024 10:14
@bartelink bartelink merged commit 831b69e into master Jan 31, 2025
5 checks passed
@bartelink bartelink deleted the cosmos-default-stj branch January 31, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant