feat(CosmosStore): Decouple Compression support #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
cosmos-fscodec-compression
branch
2 times, most recently
from
966fbf1 to
6ce9249
Compare
bartelink
force-pushed
the
cosmos-default-stj
branch
from
d0c0334 to
be4efe3
Compare
bartelink
force-pushed
the
cosmos-fscodec-compression
branch
from
c617f6a to
197236c
Compare
bartelink
force-pushed
the
cosmos-fscodec-compression
branch
from
89ccea3 to
4028959
Compare
bartelink
force-pushed
the
cosmos-fscodec-compression
branch
from
4028959 to
4c06e81
Compare
bartelink
force-pushed
the
cosmos-fscodec-compression
branch
12 times, most recently
from
5b790a9 to
13d9184
Compare
bartelink
force-pushed
the
cosmos-fscodec-compression
branch
from
13d9184 to
3002466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the store encoding agnostic, to align with how Equinox.DynamoStore works.
This enables consumption of the events without being reliant on an Equinox store impl to interpret the encoded data
In particular, in the case of reactions processing, it allows one to opt out of decoding events that one will ultimately drop rather than process. Where that encoding involves compression, that also avoids the CPU and memory cost of doing inflation.
This can also provide better control in the context of integration testing.
See jet/FsCodec#126, which provides the API that replaces the functionality being pushed out.