Fix IllegalStateException
in HttpChannelState.completed()
after abort()
#12545
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12520
The following stack trace is logged when a certain sequence of events is happening in the FSM:
These are the calls and states that triggers this bug:
abort()
incorrectly moves the request state toCOMPLETED
when it changes the state to WOKEN: this transition requires a redispatch that eventually callscompleted()
while the request state already is at its terminal position.See #11210 as the same problem was fixed in EE10, but the fact that EE9 might have a similiar problem was blurred by the fact that the original issue had to do with GZIP which was buggy too.