Issue #12266 - InvocationType improvements and cleanups. #12551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the work for the server-side only, the client side will be done in another pull request. Previously, AbstractConnection.getInvocationType() was called by AbstractConnection.ReadCallback, but it was deprecated and is now removed, along with all its overrides. This mechanism is now replaced by using a specific Callback implementation for each AbstractConnection subclass. For example, HttpConnection uses HttpConnection.FillableCallback that in turn asks the InvocationType to the Server, and therefore the `Handler` tree. Restored synchronous code for ServerFCGIConnection.close(), ensuring super.close() is always called. Ensuring that in HttpConnection.close(), super.close() is always called. Signed-off-by: Simone Bordet <[email protected]>
|
@gregw @lorban I decided to split #12299 into server (this PR) and client (a future PR). The original problem is that we can easily guarantee user code invoked by a virtual thread in the server, but not so much in the client (I know). This PR cleans up the code for the server, mostly just removing deprecated code and little other cleanups. The work to be done for the client is larger, and will be address later in a different PR, and eventually #12299 will be closed without merging it. |
Signed-off-by: Simone Bordet <[email protected]>
Improved messages used on more modules
…cationtype-cleanups'. Signed-off-by: Simone Bordet <[email protected]>
…for idle timeout and failure tasks. * Small code improvements. Signed-off-by: Simone Bordet <[email protected]>
… error response) and the promise (resetting the stream). Signed-off-by: Simone Bordet <[email protected]>
gregw
requested changes
Nov 20, 2024
...ttp2-server/src/main/java/org/eclipse/jetty/http2/server/internal/HTTP2ServerConnection.java
Outdated
Show resolved
Hide resolved
...ttp2-server/src/main/java/org/eclipse/jetty/http2/server/internal/HTTP2ServerConnection.java
Outdated
Show resolved
Hide resolved
...-http3-server/src/main/java/org/eclipse/jetty/http3/server/HTTP3ServerConnectionFactory.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/AbstractConnection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
Nov 21, 2024
...etty-client/src/main/java/org/eclipse/jetty/client/ProxyProtocolClientConnectionFactory.java
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ThreadPool.java
Outdated
Show resolved
Hide resolved
…cationtype-cleanups'. Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
sbordet
deleted the
fix/jetty-12.1.x/12266/server-invocationtype-cleanups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work for the server-side only, the client side will be done in another pull request.
Previously, AbstractConnection.getInvocationType() was called by AbstractConnection.ReadCallback, but it was deprecated and is now removed, along with all its overrides.
This mechanism is now replaced by using a specific Callback implementation for each AbstractConnection subclass. For example, HttpConnection uses HttpConnection.FillableCallback that in turn asks the InvocationType to the Server, and therefore the
Handlertree.Restored synchronous code for ServerFCGIConnection.close(), ensuring super.close() is always called. Ensuring that in HttpConnection.close(), super.close() is always called.