Promise (rejections) handling #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to bump this one. This is a very minor fix. If there's any interest in merging it I can rebase it to the current version and raise a new PR |
ryus08
reviewed
Jul 29, 2023
index.js
Outdated
| @@ -46,7 +46,7 @@ function unless(middleware, options) { | |||
| return next(); | |||
| } | |||
|
|
|||
| middleware(req, res, next); | |||
| return middleware(req, res, next); | |||
There was a problem hiding this comment.
Suggested change
| return middleware(req, res, next); | |
| try { | |
| return middleware(req, res, next); | |
| } catch (err) { | |
| return next(err); | |
| } |
ryus08
approved these changes
Jul 29, 2023
|
This also bit me. express5 is still (a year after the last beta release) still in beta though. So we might also want the try-catch so this works in express4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using express v5 (currently in beta) or express-async-errors promises returned from a middleware are handled correctly and errors are forwarded to the error handler using next(). Since in newer versions of node promise rejections cause the process to crash, this fix will prevent that from happening.
Solves #31