You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
@suragch There are several other forks that are available already. I was hoping to not have to start a new repo—to make it easier on current users. But we haven't heard from @jgilfelt for awhile. 😢
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you would like, I can pick up maintenance for awhile. (I still use this project for some of my company's projects anyway.)
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reliable fork that keeps this going with gradle updates etc?
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomventom Not that I'm aware of. But you can always check the Insights->Network page and ask the individuals there in their repos.
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jon-adams That would be nice. Fork it and start a new jCenter repository.
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suragch There are several other forks that are available already. I was hoping to not have to start a new repo—to make it easier on current users. But we haven't heard from @jgilfelt for awhile. 😢
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember hearing @ranaparamveer was going to maintain the library on his fork. Is that correct? https://github.com/ranaparamveer/android-sqlite-asset-helper/
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kisty yes. :)
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranaparamveer has already published instructions to get the library on jitpack. Also, I see that @MarcoMirisola's fork addresses leaks, may be worth applying to that ( MarcoMirisola@a831cc0).
Perhaps we could find some candidates who would be up for maintaining it?
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, @jgilfelt once there's someone to transfer it, can you hand over the repo somehow so that the old abandoned one doesn't get seen? https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kisty, the leak issue mentioned by MarcoMirisola/android-sqlite-asset-helper@a831cc0 is already patched into repo i'm maintaining. Please check and let me know if any other issue needs to be resolved.
74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranaparamveer It looks like you haven't applied the
super.close()and the otherdb.close()call from @MarcoMirisola's patch74a9b0dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check:
closing the database on force upgrade
super.close