fix redirectOnDirectory #28
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i://site/staticFolder for example). Broke relative links in child pages
|
This redirect strategy/fix doesn't work on all clients (Android's Buran is a big outlier here), but it works on many others (Lagrange, Deedum, Xenia). I'm guessing this is implementation-specific and not the server's fault. I also noticed going to "gemini://site" causes issues, but that might be outside the scope of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No redirects were happening when browsing a static folder without a trailing backslash, despite the flag. (gemini://site/staticFolder for example, wouldn't redirect to /staticFolder/). This broke relative links